-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docstrings to cwstring and transcode #17218
Conversation
conversion provided by `Cwstring` is if the function is called multiple times with the | ||
same argument. | ||
|
||
This is only available on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this mention that this is supposed to be used via Cwstring
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it? From what I can tell, the following are equivalent:
ccall(....,Cwstring, str)
or
cwstr = cwstring(str)
ccall(....,Ptr{Cwchar_t}, cwstr)
the advantage of the 2nd one is that if you have to call the function multiple times, you only have to do the conversion once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Cwstring was exported, but this was not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @Keno is right: Cwstring
appears in base/exports.jl but not cwstring
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't exported, but is that any reason not to document it?
6c70f73
to
d98b022
Compare
I realise these functions aren't exported, but probably good to have documented (we may want to export The only thing that isn't documented is the recommended way to get a |
Can anyone explain the justification for only defining |
The definition of |
No description provided.