Loosen the signature on indices passed to _flatten. Fixes #17275. #17283
Conversation
| @inline _flatten(out, i::Integer, I...) = _flatten((out..., i), I...) | ||
| @inline _flatten(out, i::CartesianIndex, I...) = _flatten((out..., i.I...), I...) | ||
| CartesianIndex(index::Union{Integer, CartesianIndex}...) = CartesianIndex(flatten(index)) | ||
| Base.@pure flatten(I) = (_flatten(I...)...,) |
There was a problem hiding this comment.
is this different than the flatten in iterators.jl ?
There was a problem hiding this comment.
It produces the same outcome, but it's non-lazy. Note that I'm not importing Base.flatten, so this doesn't "globally" extend flatten.
There was a problem hiding this comment.
fwiw, I think a pure function should usually not be extended, but I'm not certain.
There was a problem hiding this comment.
You mean, there should be only one method?
There was a problem hiding this comment.
perhaps. although more importantly, external code need to be careful about how they overload it (e.g. don't write code that could trigger a #265-style error)
There was a problem hiding this comment.
For sure. Come to think of it, I don't need the @pure annotation on _flatten, just on flatten. (right?)
The only reason it was marked pure is because of #17126, but this flatten has since been redesigned several times, and in testing with this version I'm getting equal performance with @inline. So I'll change it.
Ref #17275.