Something is wrong with inference of promote_op on Float16 #17394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please revert this if you can fix it
| @@ -2770,7 +2770,12 @@ let types = (Base.BitInteger_types..., BigInt, Bool, | |||
| Complex{Int}, Complex{UInt}, Complex32, Complex64, Complex128) | |||
| for S in types | |||
| for op in (+, -) | |||
| T = @inferred Base.promote_op(op, S) | |||
| if S === Float16 # type instability here? | |||
| @test_broken @inferred Base.promote_op(op, S) | |||
There was a problem hiding this comment.
d'oh, I am not using @test_broken correctly here
fixed in #17396
This was referenced Jul 13, 2016
This was referenced Jul 20, 2016
PallHaraldsson
pushed a commit
to PallHaraldsson/julia
that referenced
this pull request
Aug 15, 2016
Since test_broken is not good for things that currently error but when fixed will return non-boolean. If you know how to fix the inference issue and get tests to pass with JuliaLang#17394 (377dede) reverted, then please do so and ignore this change.
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Since test_broken is not good for things that currently error but when fixed will return non-boolean. If you know how to fix the inference issue and get tests to pass with JuliaLang#17394 (377dede) reverted, then please do so and ignore this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17313 passed tests a few days ago so this is probably a recent regression. There's a long queue on Travis (pyjulia was stuck blocking the entire JuliaLang queue for many hours earlier today due to misformatted yaml) but AppVeyor is totally idle right now, so if this passes on AppVeyor and nobody can propose a real fix by then I'll merge just so master isn't failing tests. Please revert this commit if you can fix the issue.