make object_ids and hashes in precompiled modules more stable #17405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #17043? |
|
Yes, it should. |
JeffBezanson
force-pushed
the
jb/stableids
branch
from
382e98f to
9922032
Compare
|
@vtjnash ok to merge? |
| if (jl_egal(dtv->name->primary, v)) | ||
| return bitmix(bitmix(h, dtv->name->uid), 0xaa5566aa); | ||
| return bitmix(bitmix(h, dtv->name->uid), hash_svec(dtv->parameters)); | ||
| return bitmix(~dtv->name->hash, hash_svec(dtv->parameters)); |
There was a problem hiding this comment.
might it be worthwhile to have a special case for emptysvec (microoptimization) for jl_f_is & hash?
return dta->name == dtb->name &&
((dta->parameters == jl_emptysvec) == (dtb->parameters == jl_emptysvec)) &&
compare_svec(dta->parameters, dtb->parameters);
|
yes, lgtm |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes object_id and the default hash function reliable for types in precompiled modules.
I also discovered that module UUIDs were not very unique, since
uv_nowis not updated very often. Many submodules of Base actually had the same UUID.