Augment convert's documentation with a note on aliasing #17519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert's result may alias part or all of convert's second argument when that argument is a collection or composite.
| julia> z === x | ||
| false | ||
|
|
||
| julia> z.colptr === x.colptr |
There was a problem hiding this comment.
this partial aliasing seems really undesirable to me.
There was a problem hiding this comment.
sure, all aliasing is a bit scary when mutation is widespread, but partial aliasing of only some fields is even moreso
There was a problem hiding this comment.
Agreed, it's disquieting and warrants care.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment convert's documentation with a brief section on potential aliasing between convert's second argument and result. Best!