Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore type parameter for elementwise ops (fix #17794) #17798

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

pabloferz
Copy link
Contributor

Sorry for this one.

Take away leasson: When modifying functions that involve arrays, consult @nanosoldier before merging.

@tkelman
Copy link
Contributor

tkelman commented Aug 4, 2016

@nanosoldier runbenchmarks(ALL, vs = ":master")

@timholy
Copy link
Member

timholy commented Aug 4, 2016

@nanosoldier is sometimes a very harsh taskmaster, as anyone who has monkeyed with the bounds-checking code can attest. But obviously a good thing.

@tkelman tkelman merged commit e68bc89 into JuliaLang:master Aug 4, 2016
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

tkelman added a commit that referenced this pull request Aug 4, 2016
@pabloferz pabloferz deleted the pz/elwise branch August 12, 2016 11:03
tkelman added a commit that referenced this pull request Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants