Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @threadcall argument passing. #17823

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Fix @threadcall argument passing. #17823

merged 1 commit into from
Aug 8, 2016

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 4, 2016

Fixes #17819. Also document not being allowed to call back into Julia.

@maleadt maleadt changed the title Fix argument passing. Fix @llvmcall argument passing. Aug 4, 2016
@yuyichao
Copy link
Contributor

yuyichao commented Aug 4, 2016

The requirement is basically #17573, do we have that documented already?

@maleadt maleadt changed the title Fix @llvmcall argument passing. Fix @threadcall argument passing. Aug 5, 2016
Fixes #17819. Also document not being allowed to call back into Julia.
@kshyatt kshyatt added docs This change adds or pertains to documentation multithreading Base.Threads and related functionality bugfix This change fixes an existing bug labels Aug 8, 2016
@kshyatt
Copy link
Contributor

kshyatt commented Aug 8, 2016

I've restarted the OSX build which seems to have failed for other reasons. If that passes, is this PR good to go?

@tkelman
Copy link
Contributor

tkelman commented Aug 8, 2016

when you restart a travis build, please back up the log to a gist first. travis overwrites logs when you restart.

@StefanKarpinski
Copy link
Member

What even is the point of these OS X builds? Can we merge this?

@StefanKarpinski StefanKarpinski added this to the 0.5.x milestone Aug 8, 2016
@StefanKarpinski
Copy link
Member

@yuyichao: even though that's the underlying cause of this restriction, it doesn't hurt to mention in the docstring for @threadcall too.

@kshyatt
Copy link
Contributor

kshyatt commented Aug 8, 2016

when you restart a travis build, please back up the log to a gist first. travis overwrites logs when you restart.

Apologies, will do next time.

@maleadt
Copy link
Member Author

maleadt commented Aug 8, 2016

Yeah, this should be good to go. I had restarted the OS X bot already (to no avail), but forgot to mention it.

@maleadt maleadt merged commit 33c7554 into master Aug 8, 2016
@maleadt maleadt deleted the tb/threadcall_args branch August 8, 2016 20:39
@yuyichao
Copy link
Contributor

yuyichao commented Aug 8, 2016

@StefanKarpinski I'm only asking do we have that documented already?

@tkelman
Copy link
Contributor

tkelman commented Aug 9, 2016

when something persistently fails, look more into the reasons next time

@maleadt
Copy link
Member Author

maleadt commented Aug 9, 2016

I did, and even though I should have spotted the ccall failure, the logs always ended in:

ErrorException("could not load library "libopenblas"
dlopen(libopenblas.dylib, 1): image not found")
    From worker 8:       * examples              in  33.75 seconds, maxrss  474.41 MB
The job exceeded the maximum time limit for jobs, and has been terminated.

So I assumed the failure to be unrelated (as it often happens)... Will be more careful next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug docs This change adds or pertains to documentation multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants