Set an RPATH on all libraries requiring fortran in binary-dist #17901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
added
building
| cd $private_libdir | ||
| for file in openlibm quadmath gfortran openblas arpack lapack openspecfun; do | ||
| for dylib in $(ls lib$file*.so* 2>/dev/null); do | ||
| patchelf --set-rpath \$ORIGIN $dylib |
There was a problem hiding this comment.
do we have the PATCHELF exported in a way that would propagate? someone might have it somewhere else, but I guess that's a second-order concern here
There was a problem hiding this comment.
yes, we build patchelf ourself and call it $(PATCHELF)
There was a problem hiding this comment.
That variable is only set in deps/, if you feel like rearranging things and threading it through, be my guest, but this code catches patchelf globally or in usr/tools, so I don't really see the need to do the extra work to make it work with an override PATCHELF.
|
This should help, thanks |
|
Somebody could override it, I suppose, but would such a somebody be making binary-dists, who knows. I don't think I particularly care. |
tkelman
pushed a commit
that referenced
this pull request
Aug 11, 2016
(cherry picked from commit 8615732)
Closed
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tkelman see if this is what you had in mind