Add missing tests for diagonal and uniformscaling #17921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
test
| @@ -116,6 +123,12 @@ for relty in (Float32, Float64, BigFloat), elty in (relty, Complex{relty}) | |||
| @test Ac_mul_B!(copy(D), copy(b)) ≈ full(D)'*full(b) | |||
| end | |||
|
|
|||
| #a few missing mults | |||
| bd = Bidiagonal(D2) | |||
| @test A_mul_Bt(D,D2) ≈ full(D)*full(D2).' | |||
There was a problem hiding this comment.
I wanted to make sure I would get this method. Is there a way to use @which to see what (*) will call?
There was a problem hiding this comment.
Do you want me to change it, @andreasnoack, or is this ok as is?
There was a problem hiding this comment.
Is there a way to use
@whichto see what (*) will call?
It used to work but then #17469
I think it would be good to change this. Ax_mul_Bx are not really meant to be used.
|
Are the test failures unrelated (looks like it to me)? |
| bd = Bidiagonal(D2) | ||
| @test D*D2.' ≈ full(D)*full(D2).' | ||
| @test D2*D.' ≈ full(D2)*full(D).' | ||
| @test D2*D' ≈ full(D2)*full(D)' |
There was a problem hiding this comment.
these don't depend on v or U, I don't think they need to run twice
tkelman
pushed a commit
that referenced
this pull request
Aug 20, 2016
* Add missing tests for diagonal and uniformscaling * Change A_mul_B to * * Moved things out of nested loop that don't need to be there (cherry picked from commit ee80a0c)
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
* Add missing tests for diagonal and uniformscaling * Change A_mul_B to * * Moved things out of nested loop that don't need to be there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.