improve correctness of fieldtype_tfunc #17953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vararg is only exact if in covariant position also make getfield_tfunc monotonic for the case where the type has one field, to avoid the same bug fix #16530
JeffBezanson
added
backport pending 0.5
bugfix
tkelman
pushed a commit
that referenced
this pull request
Aug 20, 2016
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
the getfield_tfunc was missing a test for whether the fields were all equivalent before concluding that the result type was exact fixes the fix JuliaLang#17953 fix JuliaLang#18037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should trust the return value 'exact' that was meticulously computed for getfield_tfunc,
instead of trying to recompute it (badly)
also make getfield_tfunc monotonic for the case where the type has one field
fix #16530