Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for 15913 and 15896 #17991

Merged
merged 2 commits into from
Aug 20, 2016
Merged

Add test for 15913 and 15896 #17991

merged 2 commits into from
Aug 20, 2016

Conversation

ranjanan
Copy link
Contributor

This tests that macros with kwargs throws a syntax error.

This adds a test for #15913, which fixed #15896

@ranjanan
Copy link
Contributor Author

Travis timed out

@tkelman tkelman added test This change adds or pertains to unit tests backport pending 0.5 labels Aug 12, 2016
@@ -667,3 +667,6 @@ end
let str = "[1] [2]"
@test_throws ParseError parse(str)
end

# issue 15896 and PR 15913
@test_throws ErrorException eval(:(macro test(d; y=0) end))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give this a more specific name, test15896 just so we're sure which error we're getting

@tkelman tkelman merged commit 6f2c1c4 into JuliaLang:master Aug 20, 2016
tkelman pushed a commit that referenced this pull request Aug 20, 2016
* Add test for 15913 and 15896

* Change name of test

(cherry picked from commit 6f2c1c4)
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
* Add test for 15913 and 15896

* Change name of test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Varargs inside macros swallow keyword arguments
2 participants