Fix #17956 and add tests #18012
Merged
Fix #17956 and add tests #18012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| io = IOBuffer() | ||
| show(io, ENV) | ||
| s = takebuf_string(io) | ||
| @test contains(s, k1) |
There was a problem hiding this comment.
should we be even more specific and check for "$k1 => $k1" (maybe with some whitespace padding as needed)?
There was a problem hiding this comment.
I have updated it to:
@test contains(s, "$k1=$k1")
@test contains(s, "$k2=$k2")
…d no other associative type implement the method.
|
Thank you! Good catch. Off-by-one errors are annoying. |
tkelman
pushed a commit
that referenced
this pull request
Aug 20, 2016
Sacha0
added
deprecation
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 14, 2017
tkelman
pushed a commit
that referenced
this pull request
May 16, 2017
singam-sanjay
pushed a commit
to singam-sanjay/julia
that referenced
this pull request
May 16, 2017
tkelman
pushed a commit
that referenced
this pull request
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17956 and add tests for the bug. The bug was introduced in 103db50 cc: @StefanKarpinski
PR commits changes:
env.jltest to it own file intestdelete!(ENV, k ,def)as it is inherently type unstable and no other associative type implement the method.withenvinlineThe deprecation of
delete!(ENV, k ,def)should not be backported, but the rest of the commits should.