make dlopen more conservative about opening files the user didn't request #18061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #ifdef _OS_WINDOWS_ | ||
| else if (modname[1] == ':') { |
There was a problem hiding this comment.
By the way, I noticed that this line was both incorrect and a potential buffer overrun if modname is an empty string. My new version checks that modname[0] is nonzero.
|
LGTM. |
|
Got |
|
yes, that's been a common occurrence. lgtm to squash and merge. |
|
Yay, Travis passed this time. Let's merge when AppVeyor is green. |
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
…uest (JuliaLang#18061) * make dlopen more conservative about opening files the user didn't request * update manual * recognize \server\foo and /foo/bar absolute paths on windows, similar to isabspath * simplify isabspath from init.c and use it in dlopen instead of duplicating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the
dlopenimplementation in Julia in order to document its behavior of appending thedlext(.so,.dll, or.dylib) and searchingDL_LOAD_PATH, and I noticed that its attempts to search for the library path were a bit more aggressive than seemed advisable.This patch, in addition to improving the docs, makes
dlopenmore conservative in the following ways:dlopen("foo.dlext")no longer looks forfoo.dlext.dlext(whereas it currently looks for this beforefoo.dlext). If the user explicitly supplies the.dlext, it seems unexpected that it would openfoo.dlext.dlextinstead.dlopen("/path/to/foo")no longer searches/bar/path/to/foowhere/baris inDL_LOAD_PATHAlso, as an optimization, I changed it to only call
jl_dlopen_soname(on Linux and BSD) if the library name is not an absolute path and does not have an extension, since the soname map implemented by that function only works for library names without extensions or paths.