Bugfix #18073 #18105
Merged
Bugfix #18073 #18105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you amend your commit message to be a bit more descriptive? |
Add default (true/false) argument to reduce argument so that any([]) == false and all([]) == true. (Previously these raised an exception due to reducing an empty list.)
dbeach24
force-pushed
the
djcb/bugfix-18073
branch
from
7cade48
to
c1b10d3
Compare
|
What happened here? I can't see a relationship between the AppVeyor failure and my PR... |
|
Thanks! |
|
Should this have gone directly onto the release branch. cc @tkelman |
|
@dbeach24 In the future please don't open PRs against the release branch. The text showing the target branch is small and it's hard to get into the habit of reading it. |
|
Yeah, I didn't notice that at all. |
|
At least now github lets us edit that, but you have to catch it before merging. |
|
Sorry for creating more heat than light! In the future I'll create my PRs against master. |
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
fix JuliaLang#18073: `any([])` and `all([])` (JuliaLang#18105) (cherry picked from commit d259be5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix and tests for issue with calling
any/allon an emptyeltype() == Anycollection. #18073