Expose MEMDEBUG, and use it to fix the #14173 test #18143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,14 @@ JL_DLLEXPORT uint32_t jl_get_LLVM_VERSION(void) | |||
| ; | |||
| } | |||
|
|
|||
| extern "C" JL_DLLEXPORT int8_t jl_is_memdbg() { | |||
There was a problem hiding this comment.
How about spelling this out as jl_is_memdebug since remembering that these are spelled differently is going to be impossible? I know this isn't going to be heavily used, but still.
|
osx travis had what look like fluke download failures, log backed up to https://gist.github.com/eeed4fbf76e125a4abf9d990ad791e07 and restarted |
|
OS X testing timed out: https://gist.github.com/maleadt/29594fad30c79edf26cc3f4f3f02ef3d |
|
And this time the |
maleadt
added a commit
that referenced
this pull request
Aug 20, 2016
Expose MEMDEBUG, and use it to fix the #14173 test
maleadt
added
backport pending 0.5
test
maleadt
added a commit
that referenced
this pull request
Aug 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18117