Add more methods to convert from AbstractArray to Array #18262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref. #17848, which seemed in good shape as of last activity. Fell by the wayside? Best! |
|
Ah, indeed, let's merge the older PR then. |
|
Probably good to add these tests too though, since they're slightly different. |
|
Yeah. Let's merge the other PR, and I'll rebase this one on top of master. |
kshyatt
added
linear algebra
These were not tested systematically, and are more generally useful to test conversions from AbstractArray.
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
…uliaLang#18262) These were not tested systematically, and are more generally useful to test conversions from AbstractArray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion to Vector and Matrix without element type was not supported.
This notably affected ReshapedArrays.
I hit this while trying to convert a
NullableArrayto aMatrix. This should probably be backported.