Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for isdefined #18345

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Fix docs for isdefined #18345

merged 1 commit into from
Sep 5, 2016

Conversation

simonster
Copy link
Member

@simonster simonster commented Sep 3, 2016

  • isdefined(object, index::Int) is implemented but was not documented
  • isdefined(a::AbstractArray, index::Int) was wrong in the sense that isdefined does something different for Arrays than AbstractArrays.
  • Added a note to try to convince people to use isassigned with arrays, since isdefined doesn't do the expected thing for AbstractArrays.


Tests whether an assignable location is defined. The arguments can be a module and a symbol,
a composite object and field name (as a symbol), or an array and index. With a single
symbol argument, tests whether a global variable with that name is defined in
a composite object and field name (as a symbol) or index, or an Array and index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code quote Array ?

@simonster
Copy link
Member Author

Pretty sure that Travis error is not related to this PR...


.. Docstring generated from Julia source

Tests whether an assignable location is defined. The arguments can be a module and a symbol, a composite object and field name (as a symbol), or an array and index. With a single symbol argument, tests whether a global variable with that name is defined in ``current_module()``\ .
Tests whether an assignable location is defined. The arguments can be a module and a symbol, a composite object and field name (as a symbol) or index, or an Array and index. With a single symbol argument, tests whether a global variable with that name is defined in ``current_module()``\ .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a genstdlib run here?

@tkelman
Copy link
Contributor

tkelman commented Sep 4, 2016

lgtm now

@simonster simonster merged commit 6bb08bf into master Sep 5, 2016
@simonster simonster deleted the sjk/isdefined-doc branch September 5, 2016 00:55
tkelman pushed a commit that referenced this pull request Sep 6, 2016
(cherry picked from commit 00cb3f7)
ref #18345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants