-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for isdefined #18345
Merged
Merged
Fix docs for isdefined #18345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
Tests whether an assignable location is defined. The arguments can be a module and a symbol, | ||
a composite object and field name (as a symbol), or an array and index. With a single | ||
symbol argument, tests whether a global variable with that name is defined in | ||
a composite object and field name (as a symbol) or index, or an Array and index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code quote Array ?
simonster
force-pushed
the
sjk/isdefined-doc
branch
from
September 3, 2016 21:44
bf1b993
to
b848c3a
Compare
Pretty sure that Travis error is not related to this PR... |
simonster
force-pushed
the
sjk/isdefined-doc
branch
from
September 4, 2016 03:27
b848c3a
to
9033dff
Compare
|
||
.. Docstring generated from Julia source | ||
|
||
Tests whether an assignable location is defined. The arguments can be a module and a symbol, a composite object and field name (as a symbol), or an array and index. With a single symbol argument, tests whether a global variable with that name is defined in ``current_module()``\ . | ||
Tests whether an assignable location is defined. The arguments can be a module and a symbol, a composite object and field name (as a symbol) or index, or an Array and index. With a single symbol argument, tests whether a global variable with that name is defined in ``current_module()``\ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a genstdlib run here?
simonster
force-pushed
the
sjk/isdefined-doc
branch
from
September 4, 2016 19:11
9033dff
to
00cb3f7
Compare
lgtm now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isdefined(object, index::Int)
is implemented but was not documentedisdefined(a::AbstractArray, index::Int)
was wrong in the sense thatisdefined
does something different for Arrays than AbstractArrays.isassigned
with arrays, sinceisdefined
doesn't do the expected thing for AbstractArrays.