Add @__DIR__ and document use in pkgs. Fix #12120 #18380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
added
needs tests
|
Added tests and docs. |
| package ``FooBar`` needs to load ``foo.csv`` from the ``data`` directory, use the following code:: | ||
|
|
||
| datapath = joinpath(@__DIR__, "..", "data") | ||
| foo = readcsv(joinpath(datapath, "foo.csv") |
tkelman
removed
needs docs
|
Clumsy merge. But this will get squashed anyways, am I right? |
|
it should if you don't want to do it yourself (best to make pr's from branches other than master of your fork in the future) |
|
@tkelman Forgetting to branch belongs to the things that happen in those quick-fix PRs past one's bedtime. I promise to be fully awake next time. 😉 |
|
oh and the squash merge should remember to remove the [ci skip]s from the intermediate commits since you do want ci to run on the merge. |
Add test. Add docs. Move docstrings for @__FILE__ and @__DIR__ inline. Missing paren. Rephrase example.
|
Squashed and CI passed. |
|
Nice work @helgee. Good candidate to add to Compat so packages can start using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: #12120