Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18544, cmdlineargs test failing in Mac binary due to default jul… #18545

Merged
merged 2 commits into from
Sep 17, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Sep 16, 2016

…iarc

Pass through ENV["PATH"] in the setenv call since it is read from in
https://github.com/JuliaLang/julia/blob/v0.5.0-rc4/contrib/mac/juliarc.jl

@scottsallberg can you test if making this change to /Applications/Julia-0.5.app/Contents/Resources/julia/share/julia/test/cmdlineargs.jl fixes #18544 for you?

@tkelman tkelman added test This change adds or pertains to unit tests backport pending 0.5 labels Sep 16, 2016
tkelman added a commit that referenced this pull request Sep 16, 2016
…iarc

Pass through `ENV["PATH"]` in the `setenv` call since it is read from in
https://github.com/JuliaLang/julia/blob/v0.5.0-rc4/contrib/mac/juliarc.jl
(cherry picked from commit db01a8f)
ref #18545

also make the test a little more robust against contents of /tmp
(cherry picked from commit ffbb0eb)
@tkelman tkelman merged commit 303adc9 into master Sep 17, 2016
@tkelman tkelman deleted the tk/fix18544 branch September 17, 2016 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base.runtests() failed
1 participant