fetch is a noop when on the same worker #19044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Oct 20, 2016
|
LGTM. Please merge after formatting changes. |
tkelman
reviewed
Oct 21, 2016
kshyatt
added
docs
I was quite confused by this example, since I didn't realize that there is a `getindex(f::Future, args...) = getindex(fetch(f), args...)`. Because of this I misinterpreted the example (my first conclusion: `remote_call` must magically unpack the `Future`). Also, it didn't really make clear, that fetch turns into a noop if applied to a `Future` from the same worker. I tried to add this information in a concise way.
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
I was quite confused by this example, since I didn't realize that there is a `getindex(f::Future, args...) = getindex(fetch(f), args...)`. Because of this I misinterpreted the example (my first conclusion: `remote_call` must magically unpack the `Future`). Also, it didn't really make clear, that fetch turns into a noop if applied to a `Future` from the same worker. I tried to add this information in a concise way.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
I was quite confused by this example, since I didn't realize that there is a `getindex(f::Future, args...) = getindex(fetch(f), args...)`. Because of this I misinterpreted the example (my first conclusion: `remote_call` must magically unpack the `Future`). Also, it didn't really make clear, that fetch turns into a noop if applied to a `Future` from the same worker. I tried to add this information in a concise way.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
I was quite confused by this example, since I didn't realize that there is a `getindex(f::Future, args...) = getindex(fetch(f), args...)`. Because of this I misinterpreted the example (my first conclusion: `remote_call` must magically unpack the `Future`). Also, it didn't really make clear, that fetch turns into a noop if applied to a `Future` from the same worker. I tried to add this information in a concise way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quite confused by this example, since I didn't realize that there is a
getindex(f::Future, args...) = getindex(fetch(f), args...).Because of this I misinterpreted the example (my first conclusion:
remote_callmust magically unpack theFuture).Also, it didn't really make clear, that fetch turns into a noop if applied to a
Futurefrom the same worker.I tried to add this information in a concise way.
If I failed at this, it'd be nice if someone else could rewrite this text ;)