Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates enum capitalization to be more consistent with Julia style #19506

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

ssfrr
Copy link
Contributor

@ssfrr ssfrr commented Dec 5, 2016

I don't think there's anywhere else where we use all-caps for a type name. Also in one place we had the enum values capitalized. This brings the docs in-line with what's used in the tests.

@nalimilan
Copy link
Member

For the type indeed camel case is the convention. Though for values, constants are often written in all caps. See for example those under LibGit2.Consts. It would be good to choose a common convention for constants and enums.

@nalimilan nalimilan added the docs This change adds or pertains to documentation label Dec 5, 2016
@nalimilan nalimilan mentioned this pull request Dec 5, 2016
@StefanKarpinski
Copy link
Member

We definitely do need to pick a common convention.

@nalimilan
Copy link
Member

@StefanKarpinski But if you don't make that choice, who will? ;-)

@simonbyrne simonbyrne added the needs decision A decision on this change is needed label Dec 12, 2016
@tkelman
Copy link
Contributor

tkelman commented Dec 17, 2016

+1 for this, but needs rebase

@StefanKarpinski StefanKarpinski modified the milestones: 0.6.0, 0.6.x Jan 3, 2017
@JeffBezanson
Copy link
Member

+1

@ssfrr
Copy link
Contributor Author

ssfrr commented Jan 3, 2017

thanks for the bump on this, I'm updating now. should I skip CI on this to save travis time, or run so the doctest change gets tested?

@KristofferC
Copy link
Member

Queue doesn't look that bad so I think running through CI should be fine.

@ssfrr
Copy link
Contributor Author

ssfrr commented Jan 3, 2017

Travis is failing with errors like:

du: cannot access `/tmp/julia/*': No such file or directory

@tkelman
Copy link
Contributor

tkelman commented Jan 4, 2017

that was #19848 - logs would have looked the same as https://travis-ci.org/JuliaLang/julia/builds/188622631, restarted here

@ssfrr
Copy link
Contributor Author

ssfrr commented Jan 4, 2017

now it's just failing on 32-bit linux with a bunch of errors like:

Error in testset dsp:
Error During Test
  Test threw an exception of type ProcessExitedException
  Expression: dsp
  ProcessExitedException()

with various things substituted for dsp

@tkelman tkelman merged commit 7eadb55 into JuliaLang:master Jan 4, 2017
@ssfrr ssfrr deleted the fruity branch January 4, 2017 16:14
ssfrr added a commit to ssfrr/julia that referenced this pull request Oct 12, 2017
This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See JuliaLang#19506
fredrikekre pushed a commit that referenced this pull request Oct 12, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency
ararslan pushed a commit that referenced this pull request Nov 7, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 8, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 8, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 8, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 8, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 9, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 14, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
ararslan pushed a commit that referenced this pull request Nov 21, 2017
* fixes enum capitalization

This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506

* more enum consistency

(cherry picked from commit 0504584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation needs decision A decision on this change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants