-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates enum capitalization to be more consistent with Julia style #19506
Conversation
For the type indeed camel case is the convention. Though for values, constants are often written in all caps. See for example those under |
We definitely do need to pick a common convention. |
@StefanKarpinski But if you don't make that choice, who will? ;-) |
+1 for this, but needs rebase |
+1 |
thanks for the bump on this, I'm updating now. should I skip CI on this to save travis time, or run so the doctest change gets tested? |
Queue doesn't look that bad so I think running through CI should be fine. |
Travis is failing with errors like:
|
that was #19848 - logs would have looked the same as https://travis-ci.org/JuliaLang/julia/builds/188622631, restarted here |
now it's just failing on 32-bit linux with a bunch of errors like:
with various things substituted for |
This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See JuliaLang#19506
* fixes enum capitalization This brings the example in the `instances` docstring in line with the naming convention used elsewhere in the enum docs. See #19506 * more enum consistency
I don't think there's anywhere else where we use all-caps for a type name. Also in one place we had the enum values capitalized. This brings the docs in-line with what's used in the tests.