Maintain a more obvious ordering of SSL certificate locations #19556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason not to merge? |
|
Not that I can see, but that's why I opened the PR in the first place. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a more well-defined ordering of SSL certificate locations that we search, and permutes the ordering a bit to look for certificates that are more explicitly named first. This is necessary because, on some older Debian systems, the file
<openssl dir>/certs/ca.pemis actually the certificate for thedebconf.orgsite, and not the list of certificate authorities (Debian bug about this).With this patch, we pick up the more explicitly named
ca-certificates.crtfirst which fixes the issue on the machine I discovered this issue on.