Deprecate vectorized min and max over pairs of sparse matrices #19713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Dec 25, 2016
| @test_throws DimensionMismatch min(sqrfloatmat, colfloatmat) | ||
| @test_throws DimensionMismatch max(sqrfloatmat, colfloatmat) | ||
| # @test_throws DimensionMismatch min(sqrfloatmat, colfloatmat) # vectorized min no longer exists | ||
| # @test_throws DimensionMismatch max(sqrfloatmat, colfloatmat) # vectorized max no longer exists |
There was a problem hiding this comment.
how about testing that map(min, ...) still throws ?
There was a problem hiding this comment.
Sure, though those tests would be redundant with the similar tests #19690 introduces. Preference for redundancy or removal? Thanks!
There was a problem hiding this comment.
I'd prefer redundancy, since spzeros((shapeA .- 1)...) used in those tests isn't quite the same as what this was doing
There was a problem hiding this comment.
(Addressed in #19791. Thanks!)
|
Build failures seem unrelated (ref. #18588 (comment)). Best! |
|
Subsumed by #19791. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #19518 in, these vectorized
minandmaxmethods can disappear. Best!