make broadcast treat all type arguments as scalars (fix DataArrays.jl#229) #19922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.Broadcast.broadcast_containertype
is incorrect for::Type{T}
arguments to upstreambroadcast
whereT <: Union{Tuple, Ref, AbstractArray, Nullable}
, e.g.Base.Broadcast.broadcast_containertype(AbstractArray)
yieldsArray
rather thanAny
. That incorrect return causes, e.g.,This pull request addresses the above issue. Thanks to @ararslan for catching this issue in JuliaStats/DataArrays.jl#229!