Deprecate GitAnyObject -> GitUnknownObject #19935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
the
kind:deprecation
simonbyrne
reviewed
Jan 8, 2017
| @@ -7,12 +7,12 @@ module Consts | |||
| const REMOTE_ORIGIN = "origin" | |||
|
|
|||
| # objs | |||
| const OBJ_ANY = Cint(-2) | |||
There was a problem hiding this comment.
Maybe keep this the same, as the name comes from the header.
There was a problem hiding this comment.
Can do, i'll leave a comment somewhere to that effect
kshyatt
force-pushed
the
ksh/anyunknown
branch
from
79ae816
to
10ef01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #19839. Thanks to @ararslan for helping me debug this one (:wink:).