Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups, style tweaks #20031

Merged
merged 20 commits into from
Jan 18, 2017
Merged

Minor cleanups, style tweaks #20031

merged 20 commits into from
Jan 18, 2017

Commits on Jan 16, 2017

  1. remove a bunch of unnecessary blank lines 

    especially right after a block opener and right before end
    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    3352ed1 View commit details
    Browse the repository at this point in the history

  2. wrap long lines in test/linalg/lu.jl

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    cc982bd View commit details
    Browse the repository at this point in the history

  3. wrap some long lines in base/multidimensional.jl

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    a4919d8 View commit details
    Browse the repository at this point in the history

  4. space try expression over multiple lines

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    a16015a View commit details
    Browse the repository at this point in the history

  5. none of the other bullets here pretend to be sentences

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    fa30d63 View commit details
    Browse the repository at this point in the history

  6. Fix subj/verb agreement in broadcast docstring

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    9daf864 View commit details
    Browse the repository at this point in the history

  7. fix grammar in a comment

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    ded552a View commit details
    Browse the repository at this point in the history

  8. Prefer 'environment variable' spelling 

    over 'environmental variable'
    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    24e5afe View commit details
    Browse the repository at this point in the history

  9. Spell out FIFO acronym in channel documentation

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    c214ac9 View commit details
    Browse the repository at this point in the history

  10. 4 space indent control flow examples

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    1ddae06 View commit details
    Browse the repository at this point in the history

  11. don't shadow cmp function with a variable name in test/worlds.jl

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    15e8d11 View commit details
    Browse the repository at this point in the history

  12. add back test examples for isapprox 

    todo: make this a doctest
    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    ca9e10b View commit details
    Browse the repository at this point in the history

  13. Add a test that the <- operator from 19765 would have broken

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    1541b65 View commit details
    Browse the repository at this point in the history

  14. replace a let with a testset

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    73ee71b View commit details
    Browse the repository at this point in the history

  15. use logical negation instead of bitwise in triangular.jl 

    and linalg/dense.jl
    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    ac96524 View commit details
    Browse the repository at this point in the history

  16. can use deepcopy_internal without Base. qualification inside Base

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    05c8f76 View commit details
    Browse the repository at this point in the history

  17. eval Base.Test deprecations into right module

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    f397cad View commit details
    Browse the repository at this point in the history

  18. do not indent preprocessor conditionals in codegen.cpp

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    3a4afe6 View commit details
    Browse the repository at this point in the history

  19. Save some vertical space with some previously zero-argument lets

    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    e09ce52 View commit details
    Browse the repository at this point in the history

  20. Address review comments 

    remove lets where redundant with testsets

move some comments into testset descriptions
    @tkelman
    tkelman committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    d5ea348 View commit details
    Browse the repository at this point in the history