-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit calls in build scripts no longer build to abort #20070
Conversation
Continuing in |
No disagreements about it being a hack. That said I don't think that a package bug should be allowed to interrupt the build process in base. |
You can do that no matter what. |
As @tkelman mentioned #20020 (comment)
I can update the PR to spawn multiple processes if that is preferable. |
Revised the PR to spawn a new Julia process for each package build script. I should probably do some additional work on how the exceptions are being captured. |
This is still a worthwhile change, if you or anyone else has capacity to get it passing. |
Resolved conflicts. |
Nice, looks like it's working. This should theoretically not be user-visible, but will make Pkg.build a bit more robust to packages influencing one another. cc @stevengj if you're able to take a look |
Why is |
@omus would the intermediate commits pass here or should this be squashed? |
All intermediate commits pass locally. |
--eval $code | ||
``` | ||
|
||
success(pipeline(cmd, stderr=STDERR)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we do not resend stdout to STDOUT
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MXNet.jl ran into this: dmlc/MXNet.jl#265 (comment)
We need to build libmxnet via make
. The main build step requires more than 10 mins on travis-ci. But stdout is gone in Julia 0.6+, so the build got killed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an oversight. We should add a test for this.
Captures and "ignores"
exit
calls made withinbuild.jl
scripts.Closes #20020