Deprecate LibGit2.owner in favour of repository

[kshyatt]

No description provided.

[ararslan]

If I'm not mistaken, I think you need @deprecate here rather than @deprecate_binding, as the latter is for types and such. So something like

eval(Base.LibGit2, :(Base.@deprecate owner(x) repository(x)))

[ararslan]

Scratch that, apparently @deprecate_binding works just fine. TIL.

[simonbyrne]

The problem is that @deprecate (and presumably @deprecate_binding) both export. This came up in #20104. Perhaps we need a non-exporting @deprecate?

[tkelman]

was owner previously exported from the libgit2 module? if not, this would cause it to be exported which you probably don't want

[kshyatt]

It wasn't, I don't think. How can I deprecate it without exporting it?

[tkelman]

manually call depwarn. simon has a commit in one of his pr's that adds a kwarg optional argument to disable exporting for at-deprecate, but deprecate_binding is separate

[tkelman]

don't need the deprecate_binding (which will still export) if you define the method below

[ararslan]

For consistency with other deprecations, I would do

function LibGit2.owner(x)
    depwarn("owner(x) is deprecated, use repository(x) instead.", :owner)
    LibGit2.repository(x)
end

The point is the wording of the message, but note as an aside that I've left out the specification of the input type. I think it's unnecessary in this case, because existing code shouldn't be affected and new code will get a MethodError from repository for any weird input.

I'm not certain but it might even be better to do it as an eval into LibGit2:

eval(LibGit2, quote
    function owner(x)
        depwarn("owner(x) is deprecated, use repository(x) instead.", :owner)
        repository(x)
    end
end)

I only mention the latter case because I'm not sure whether the fact that the symbol :owner isn't defined in the module in which depwarn is being called matters.

[kshyatt]

@simonbyrne @tkelman @ararslan still good to merge once CI passes?

[KristofferC]

At sysimg compilation:

WARNING: Method definition owner(Any) in module LibGit2 at deprecated.jl:1807 overwritten at deprecated.jl:49.

[tkelman]

we can delete this one now that

julia/base/deprecated.jl

Line 1188 in b0a3ff5

@deprecate owner(x) repository(x) false

does it more concisely