Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing subarray test on master (partial linear indexing depwarn) #20242

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jan 26, 2017

The at-views PR (#20164) and partial linear indexing deprecation PR (#20079) each last passed CI prior to the other being merged, so CI missed an interaction between them that causes the subarray tests to fail (throwing a depwarn from an at-views test). This pull request disables the offending at-views test, following the approach applied to the equivalent tests for at-view. (Should these instead be @test_broken? Similar todos exist in the subarray tests regarding Colon.) Best!

Copy link
Member

@mbauman mbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tkelman
Copy link
Contributor

tkelman commented Jan 26, 2017

merging faster than usual so fewer currently pending ci runs will fail

@tkelman tkelman merged commit 1303dfb into JuliaLang:master Jan 26, 2017
@Sacha0 Sacha0 deleted the fixplidepwarn branch January 26, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants