eliminate REPL shell mode deprecation warnings #20494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does shell-mode have tests? |
However, this does not raise an error even with --depwarn=error so the best we can get here is a visual warning when running the tests with --depwarn=yes.
tkelman
reviewed
Feb 9, 2017
| # issue #20482 | ||
| write(stdin_write, ";") | ||
| readuntil(stdout_read, "shell> ") | ||
| write(stdin_write, "echo hello >/dev/null\n") |
There was a problem hiding this comment.
since windows shell-mode executes commands directly rather than going through a shell, I get
From worker 3: hello >/dev/null
show (2) | 19.83 | 0.32 | 1.6 | 369.99 | 1455.00
repl (3) | 9.42 | 0.16 | 1.7 | 178.81 | 1105.19
from this so I think this should be unix-only
tkelman
pushed a commit
that referenced
this pull request
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.