Implement, test, doc git descriptions for things #20885
Conversation
base/libgit2/repository.jl
Outdated
|
|
||
| * `options::DescribeOptions=DescribeOptions()` | ||
|
|
||
| Equivalent to `git-describe <commitish>`. |
There was a problem hiding this comment.
I don't think there should be a hyphen between git and describe; git describe is the CLI AFAICT
|
It might be nice to have the description interface be simply |
|
I did it this way because it's a type and otherwise it lacks a constructor. |
|
|
test/libgit2.jl
Outdated
| @@ -354,6 +354,7 @@ mktempdir() do dir | |||
| @test contains(showstr[4], "SHA:") | |||
| @test showstr[5] == "Message:" | |||
| @test showstr[6] == commit_msg1 | |||
|
|
|||
There was a problem hiding this comment.
don't add empty lines as the first or last thing in a block
|
we're in feature freeze, not the best time to be wrapping new api's |
|
@staticfloat asked for it, we can wait until we're out of FF to merge if you want. |
|
@tkelman I've rebased this against master. We're off feature freeze, right? |
|
And bumping again. Can someone ( @ararslan ? @simonbyrne ? ) please review this? |
There was a problem hiding this comment.
I made the small doc change suggested by @ararslan, LGTM once CI is done.
base/libgit2/repository.jl
Outdated
|
|
||
| * `options::DescribeOptions=DescribeOptions()` | ||
|
|
||
| Equivalent to `git-describe`. |
Now you can ask for detailed descriptions of a repo's workdir or a commit-like object within it. cc @staticfloat.