add tests for issues #10207, #10178, #12939 #21342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
test
ararslan
reviewed
Apr 10, 2017
| struct Foo <: Abs; end | ||
| struct Bar; val::Int64; end | ||
| struct Baz; val::Int64; end | ||
| f{T}(::Type{T}, x::T) = T(3) |
There was a problem hiding this comment.
Any reason not to use where here?
There was a problem hiding this comment.
I was just copying this from the issue comment.
|
Can the linked issues be closed once this PR is merged? If so, you could add text to the commit message that would auto-close them. |
|
Yes, the linked issues are fixed now. Easier to just close them than to update the commit I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.