Make libgit2 print repo path on error #21344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context-free error messages are ... not helpful
tkelman
reviewed
Apr 11, 2017
| @@ -96,7 +99,7 @@ macro check(git_func) | |||
| local err::Cint | |||
| err = $(esc(git_func::Expr)) | |||
| if err < 0 | |||
| throw(Error.GitError(err)) | |||
| throw(Error.GitError(err; path = gitdir($(esc(:repo))))) | |||
There was a problem hiding this comment.
there are a few places @check is used in functions that don't have a repo argument, like some of the GitConfig constructors
ararslan
added
domain:error handling
|
obsolete with the new Pkg manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error messages in #17994 occur because a package folder is not actually a git repository, is a bare repo (no commits), or apparently some other reasons. I had about 10 of those for various reasons, and the error messages were not helpful.
Pending more useful errors, this PR prints the libgit2 repo directory when something goes wrong, so that the problem can at least be tracked down manually.