Band aid to make threaded loop a little easier to work with #21452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/threads/bandaid
branch
from
914933e to
bb8adea
Compare
yuyichao
force-pushed
the
yyc/threads/bandaid
branch
from
bb8adea to
c9b7eac
Compare
tkelman
reviewed
Apr 21, 2017
base/threadingconstructs.jl
Outdated
| @@ -18,17 +18,25 @@ on `threadid()`. | |||
| """ | |||
| nthreads() = Int(unsafe_load(cglobal(:jl_n_threads, Cint))) | |||
|
|
|||
| # Only read/write by the main thread | |||
yuyichao
force-pushed
the
yyc/threads/bandaid
branch
from
c9b7eac to
ca77f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a warning if an error occurs in the threaded loop (Helps Exceptions dropped in multithreaded code #17532)
Make recursive threaded loops "work" (Fix recursive
@threadsblocks unsupported #18335).The proper fix will be tracked by Feature request: a work stealing threaded for loop #21017