Try to loosen cfunction optimization type check #21467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can whatever was wrong with the previous version be tested for? |
|
Nothing was wrong. It's only a performance issue. |
yuyichao
force-pushed
the
yyc/codegen/cfunction
branch
3 times, most recently
from
74ba371
to
1db0284
Compare
vtjnash
reviewed
May 22, 2017
src/ccall.cpp
Outdated
| fargt = jl_tparam0(fargt); | ||
| if (jl_has_free_typevars(fargt)) { |
yuyichao
force-pushed
the
yyc/codegen/cfunction
branch
from
1db0284
to
785ee2c
Compare
yuyichao
force-pushed
the
yyc/codegen/cfunction
branch
from
785ee2c
to
3660535
Compare
|
Any other comments? |
|
worth running nanosoldier? |
|
Kind of doubt it has anything that uses cfunction but sure.... @nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is precise now but the old one seems to be too strict since it doesn't catch passing by ref or non-leaf argument types.