Add method to isposdef! for Hermitian and Symmetric #21561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of Edit: Nvm, I think this is not an issue. |
|
@KristofferC You probably concluded that already but |
andreasnoack
approved these changes
Apr 26, 2017
ararslan
reviewed
Apr 26, 2017
test/linalg/symmetric.jl
Outdated
| @@ -129,6 +129,12 @@ let n=10 | |||
| @test det(a + a.') ≈ det(Symmetric(a + a.', :U)) | |||
| @test det(a + a.') ≈ det(Symmetric(a + a.', :L)) | |||
|
|
|||
| # isposdef | |||
| if eltya != BigFloat # isposdef not defined for Matrix{BigFloat} | |||
| @test isposdef(Symmetric(asym)) == isposdef(full(Symmetric(asym))) | |||
There was a problem hiding this comment.
Might be good to directly test the methods for the mutating version, isposdef!, that you've added here.
There was a problem hiding this comment.
Guess we should test both.
ararslan
approved these changes
Apr 26, 2017
|
Forgot to exclude |
Sacha0
reviewed
Apr 26, 2017
base/linalg/symmetric.jl
Outdated
| @@ -264,6 +264,8 @@ det(A::Symmetric) = det(bkfact(A)) | |||
| inv{T<:BlasFloat,S<:StridedMatrix}(A::Hermitian{T,S}) = Hermitian{T,S}(inv(bkfact(A)), A.uplo) | |||
| inv{T<:BlasFloat,S<:StridedMatrix}(A::Symmetric{T,S}) = Symmetric{T,S}(inv(bkfact(A)), A.uplo) | |||
|
|
|||
| isposdef!(A::HermOrSym{<:BlasFloat, <:StridedMatrix}) = ishermitian(A) && LAPACK.potrf!(A.uplo, A.data)[2] == 0 | |||
There was a problem hiding this comment.
Extraneous space prior to <:StridedMatrix?
fredrikekre
force-pushed
the
fe/isposdef
branch
from
dbc0338
to
530496e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JuliaLang/LinearAlgebra.jl#422
Perhaps too late for 0.6, but here it is