Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor doctest fixes #21676

Merged
merged 3 commits into from
May 3, 2017
Merged

Minor doctest fixes #21676

merged 3 commits into from
May 3, 2017

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented May 2, 2017

including #19985 (comment)

@tkelman tkelman added backport pending 0.5 docs This change adds or pertains to documentation and removed backport pending 0.5 labels May 2, 2017
ararslan
ararslan approved these changes May 2, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkelman
upgrade libssl on travis to hopefully fix curl certificate issues
82eb74c 
have only seen this on release-0.5 so far, but could hit master
or release-0.6 too if they need to build from a clean cache
@tkelman tkelman merged commit 70db8be into master May 3, 2017
@tkelman tkelman deleted the tk/shouldhavebeenadoctest branch May 3, 2017 16:05
tkelman added a commit that referenced this pull request May 4, 2017
@tkelman
fix existing doctest outputs
bc5ab11 
(cherry picked from commit 17d882b)
ref #21676
tkelman added a commit that referenced this pull request May 4, 2017
@tkelman
change a few example code blocks to doctests
d09737d 
and fix quoted output of a Cmd object

(cherry picked from commit fef650b)
ref #21676
tkelman added a commit that referenced this pull request May 4, 2017
@tkelman
upgrade libssl on travis to hopefully fix curl certificate issues
efd4df2 
have only seen this on release-0.5 so far, but could hit master
or release-0.6 too if they need to build from a clean cache

(cherry picked from commit 82eb74c)
ref #21676
tkelman added a commit that referenced this pull request May 4, 2017
@tkelman
fix existing doctest outputs
a31ac05 
(cherry picked from commit 17d882b)
ref #21676
tkelman added a commit that referenced this pull request May 4, 2017
@tkelman
change a few example code blocks to doctests
e45bb72 
and fix quoted output of a Cmd object

(cherry picked from commit fef650b)
ref #21676
tkelman added a commit that referenced this pull request May 4, 2017
@tkelman
upgrade libssl on travis to hopefully fix curl certificate issues
f71c099 
have only seen this on release-0.5 so far, but could hit master
or release-0.6 too if they need to build from a clean cache

(cherry picked from commit 82eb74c)
ref #21676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkelman @ararslan