Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for checkout #21707

Merged
merged 1 commit into from
May 7, 2017
Merged

Add example for checkout #21707

merged 1 commit into from
May 7, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented May 5, 2017

No description provided.

@kshyatt kshyatt added docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module labels May 5, 2017
@kshyatt kshyatt requested a review from ararslan May 5, 2017 04:07
ararslan
ararslan approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Sacha0
Sacha0 reviewed May 5, 2017
View reviewed changes
base/libgit2/libgit2.jl Outdated

```julia
repo = LibGit2.init(repo_path)
open(joinpath(LibGit2.path(repo),"file1"),"w") do f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, perhaps inject spaces between function arguments in this line and the similar open call below?

Sacha0
Sacha0 approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :) (Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning following whitespace fixups. Best!)

@kshyatt
Copy link
Contributor Author

kshyatt commented May 7, 2017

Whitespace addressed, going to merge <3

@kshyatt kshyatt merged commit f4cd98b into master May 7, 2017
@kshyatt kshyatt deleted the ksh/checkoutex branch May 7, 2017 03:43
tkelman pushed a commit that referenced this pull request May 14, 2017
@kshyatt @tkelman
Add example for checkout
7001598 
(cherry picked from commit 14da9d3)
ref #21707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kshyatt @Sacha0 @ararslan @tkelman