give a syntax error for repeated keyword args. fixes #16937 #21780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
breaking
|
should go in news |
|
can we avoid moving the file to history until we've tagged final? especially given the remaining item on the milestone |
|
Ok I'll drop the second commit, wait until 0.6-final, and then put in a news item here. |
|
starting a separate 0.7 section of the file without moving it yet would also not conflict with any backports. a few open pr's have done so but guess none have been merged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm ok with just adding this error without a deprecation. This should be very uncommon and never did anything useful.