Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NEWS.md entry for three-argument rem and rem2pi #21812

Merged
merged 2 commits into from
May 16, 2017
Merged

add NEWS.md entry for three-argument rem and rem2pi #21812

merged 2 commits into from
May 16, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented May 11, 2017

Clears #10946 from #21475 (comment). Best!

@Sacha0 Sacha0 added the needs news A NEWS entry is required for this change label May 11, 2017
@Sacha0 Sacha0 added this to the 0.6.0 milestone May 11, 2017
@Sacha0 Sacha0 requested a review from simonbyrne May 11, 2017 21:59
@tkelman
Copy link
Contributor

tkelman commented May 13, 2017

@simonbyrne does this look good to you?

@simonbyrne
Copy link
Contributor

The wording was slightly confusing, so I made a few tweaks.

@Sacha0
Copy link
Member Author

Sacha0 commented May 16, 2017

Thanks @simonbyrne! :)

@tkelman tkelman merged commit 8f9a948 into JuliaLang:master May 16, 2017
@tkelman tkelman removed the needs news A NEWS entry is required for this change label May 16, 2017
@Sacha0 Sacha0 deleted the news10946 branch May 16, 2017 16:35
tkelman pushed a commit that referenced this pull request May 17, 2017
@Sacha0 @tkelman
add NEWS.md entry for three-argument rem and rem2pi (#21812)
5f9a9bb 
* Add NEWS.md entry for three-argument rem and the new rem2pi (#10946).

* Clarify precise behaviour

(cherry picked from commit 8f9a948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@simonbyrne simonbyrne Awaiting requested review from simonbyrne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Sacha0 @tkelman @simonbyrne @StefanKarpinski