Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PR number to and touch up NEWS.md entry for #18754 #21842

Merged
merged 1 commit into from
May 24, 2017
Merged

add PR number to and touch up NEWS.md entry for #18754 #21842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,13 +397,13 @@ Compiler/Runtime improvements
-----------------------------

* `ccall` is now implemented as a macro,
removing the need for special code-generator support for Intrinsics.
removing the need for special code-generator support for `Intrinsics` ([#18754]).

* `ccall` gained limited support for a `llvmcall` calling-convention.
This can replace many uses of `llvmcall` with a simpler, shorter declaration.
This can replace many uses of `llvmcall` with a simpler, shorter declaration ([#18754]).

* All Intrinsics are now Builtin functions instead and have proper error checking
and fall-back static compilation support.
* All `Intrinsics` are now `Builtin` functions instead and have proper error checking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these have code meanings, should maybe just be not capitalized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed quoting and capitalization. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh they exist in Core, but are very sparsely documented in the devdocs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting and capitalization restored. How now? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure the module name is plural

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

and fall-back static compilation support ([#18754]).

Deprecated or removed
---------------------
Expand Down Expand Up @@ -509,6 +509,7 @@ Deprecated or removed
[#18644]: https://github.com/JuliaLang/julia/issues/18644
[#18660]: https://github.com/JuliaLang/julia/issues/18660
[#18690]: https://github.com/JuliaLang/julia/issues/18690
[#18754]: https://github.com/JuliaLang/julia/issues/18754
[#18777]: https://github.com/JuliaLang/julia/issues/18777
[#18839]: https://github.com/JuliaLang/julia/issues/18839
[#18931]: https://github.com/JuliaLang/julia/issues/18931
Expand Down