add NEWS.md entry for deprecation of Array(T, dims...) #21857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
May 13, 2017
NEWS.md
Outdated
| @@ -439,6 +439,11 @@ Deprecated or removed | |||
|
|
|||
| * `cummin` and `cummax` have been deprecated in favor of `accumulate`. | |||
|
|
|||
| * The idiosyncratic `Array` constructor syntax `Array(T, dims...)` has been deprecated | |||
There was a problem hiding this comment.
idiosyncratic
I am learning so many new English words reading your PR's :)
There was a problem hiding this comment.
the old syntax does match how you would call zeros or ones ... though those aren't constructors
There was a problem hiding this comment.
Would you prefer different wording? For example "The zeros(T, dims...)/ones(T, dims...)-like Array constructor syntax Array(T, dims...)..."? Or something else? Best! :)
There was a problem hiding this comment.
I think it's okay, I just wouldn't have used the word idiosyncratic here
There was a problem hiding this comment.
"idiosyncratic" and "more consistent" removed :). Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #21475. Best!