Add gvim support in edit #21873
Merged
Add gvim support in edit #21873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `gvim` is not recognized by `edit(path, line)`. I recommend to add it with option to run in background turned on.
ararslan
reviewed
May 17, 2017
| @@ -40,7 +40,7 @@ function edit(path::AbstractString, line::Integer=0) | |||
| end | |||
| background = true | |||
| line_unsupported = false | |||
| if startswith(name, "emacs") || name == "gedit" | |||
| if startswith(name, "emacs") || name == "gedit" || startswith(name, "gvim") | |||
There was a problem hiding this comment.
Seems like this belongs in the next conditional along with the other Vim variants?
There was a problem hiding this comment.
I have put it in line above because gvim is GUI based. Other vim variants run in console.
Therefore gvim should have background = true (as a separate window is opened when it is invoked) and other vims have background = false.
There was a problem hiding this comment.
Though when there's no display, gvim will run in the terminal...
There was a problem hiding this comment.
I am not a Linux expert, but as far as I understand emacs also can be run in the terminal. And secondly when one sets editor to gvim probably one wants to run it in GUI.
stevengj
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
gvimis not recognized byedit(path, line). I recommend to add it with option to run in background turned on.