Make CoreIO thread-safer #21893
Merged
Make CoreIO thread-safer #21893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
added
backport pending 0.6
multithreading
vtjnash
reviewed
May 15, 2017
| fd = STDERR_FILENO; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Sure.... In case we have anyone that somehow closed the STDIN I guess?
Also test for `fd != -1` instead since that is a defined invalid value.
yuyichao
force-pushed
the
yyc/threads/core-print
branch
from
b50cf23
to
84eeb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminded by https://discourse.julialang.org/t/status-of-threads/3729 that CoreIO isn't thread safe yet. This makes it safer.
It's pretty hacky and you can easily crash it if you pass in anything that's not STDIN or STDOUT but I think it's useful for debugging before the actual IO system is thread safe.
Now a thread safe show function can kind of be implemented as
f(x) = Core.print(sprint(show, x)).