Use VersionNumber for libllvm_version #21898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump |
|
Also should |
tkelman
reviewed
May 28, 2017
| @@ -55,7 +55,7 @@ else | |||
| endif | |||
| @echo "const libfftw_name = \"$(LIBFFTWNAME)\"" >> $@ | |||
| @echo "const libfftwf_name = \"$(LIBFFTWFNAME)\"" >> $@ | |||
| @echo "const libllvm_version = \"$$($(LLVM_CONFIG_HOST) --version)\"" >> $@ | |||
| @echo "const libllvm_version_string = \"$$($(LLVM_CONFIG_HOST) --version)\"" >> $@ | |||
There was a problem hiding this comment.
if possible to avoid occupying two names in base, would be better to do the VersionNumber conversion here
There was a problem hiding this comment.
Yeah I agree, but there isn't a way to do this without making unnecessary changes/shuffling of files. VERSION_STRING follows the same strategy as in this PR.
Any opinions on the uppercasing (in regards to consistency) ?
|
On second thought I think it's probably better to not touch the the uppercasing (at least for this PR) |
|
bump |
StefanKarpinski
approved these changes
May 31, 2017
|
Meant to squash, but clicked twice by accident. |
|
thanks! Both comments are valid so I think it's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me it looks like every usage of
libllvm_versionis better of if it was an actualVersionNumberSame with packages that use this which also just end up wrapping the string in a
VersionNumber.This makes things more convenient.