Use testsets and \approx in umfpack.jl #21904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
linear algebra
Sacha0
reviewed
May 16, 2017
test/sparse/umfpack.jl
Outdated
| end | ||
|
|
||
| @testset "Test that A[c|t]_ldiv_B!{T<:Complex}(X::StridedMatrix{T}, lu::UmfpackLU{Float64}, | ||
| # B::StridedMatrix{T}) works as expected." begin |
tkelman
reviewed
May 16, 2017
test/sparse/umfpack.jl
Outdated
| # Element promotion and type inference | ||
| @inferred lua\ones(Int, size(A, 2)) | ||
| @testset "UMFPACK wrappers" begin | ||
|
|
There was a problem hiding this comment.
blank lines at start and end of indented block aren't necessary, waste space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small follow up on the UMFPACK fix. Only substantial change is the use of
≈instead ofnorm. The old criteria were much looser than necessary.