re-enable the 0-arg MersenneTwister() constructor #21909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #16984 for context, which deprecated
MersenneTwister() = MersenneTwister(0)
.The next step here is to re-enable this constructor to be equivalent to
srand(MersenneTwister(0))
.I think that it's good for predictability that for an RNG type
T
,T([seed])
produces an RNG object equivalent tosrand(T(), [seed]))
.Accordingly,
srand(RandomDevice())
is also enabled (as a no-op).I put WIP as I'm not satisfied with my wording in the docstrings.