Mark the backtrace test as broken on FreeBSD #21917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
system:freebsd
|
I should also note that with this test marked broken, all tests pass on my build of FreeBSD. 🙂 |
tkelman
approved these changes
May 17, 2017
ararslan
added a commit
that referenced
this pull request
Apr 25, 2018
ararslan
added a commit
that referenced
this pull request
May 2, 2018
ararslan
added a commit
that referenced
this pull request
May 8, 2018
ararslan
added a commit
that referenced
this pull request
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD has the same problem as 32-bit Windows in that some information is lost in the backtrace when precompilation is enabled (see #17251). This affects the test that looks for specific contents in the backtrace. This PR simply changes the
@testto@test_brokenfor BSD systems, pending some fix for the lookup.