Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR number in NEWS.md entry for num/den rename #21943

Merged
merged 1 commit into from
May 18, 2017
Merged

Fix PR number in NEWS.md entry for num/den rename #21943

merged 1 commit into from
May 18, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented May 18, 2017

Ref. #21475. Best!

@Sacha0 Sacha0 added the needs news A NEWS entry is required for this change label May 18, 2017
@Sacha0 Sacha0 added this to the 0.6.0 milestone May 18, 2017
@fredrikekre
Copy link
Member

fredrikekre commented May 18, 2017 •
edited
Loading

This is already there, #19246 Edit: I should have read the title....

@tkelman
Copy link
Contributor

tkelman commented May 18, 2017

which do we do more of, linking to the issue #, the pr #, or both?

@Sacha0
Copy link
Member Author

Sacha0 commented May 18, 2017 •
edited
Loading

which do we do more of, linking to the issue #, the pr #, or both?

PR # I believe. But might as well have both! :) (Edit: done!)

@ararslan ararslan merged commit b94cca1 into JuliaLang:master May 18, 2017
@tkelman tkelman assigned tkelman and unassigned tkelman May 18, 2017
@Sacha0 Sacha0 deleted the news19246 branch May 19, 2017 17:11
@Sacha0 Sacha0 removed the needs news A NEWS entry is required for this change label May 19, 2017
tkelman pushed a commit that referenced this pull request Jun 3, 2017
@Sacha0 @tkelman
Fix PR number in NEWS.md entry for num/den rename (#19246). (#21943)
fb3cdff 
(cherry picked from commit b94cca1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Sacha0 @fredrikekre @tkelman @ararslan