Use the pure Julia exp function for fastmath #21948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be backported to 0.6? |
|
It should |
|
bump |
|
any way of testing these or tracking them in the benchmark suite? |
|
@eschnett could perhaps take a look and review this too. |
|
This is really straightforward all it's doing is removing the libm call and allowing the following line https://github.com/musm/julia/blob/9c7c389a449e58c27316b13e525514b11b46808a/base/fastmath.jl#L326 to call the pure julia version. |
tkelman
pushed a commit
that referenced
this pull request
Jun 3, 2017
(cherry picked from commit efca045)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when I was doing some benchmarking and found the fastmath version to be a bit slower, only realizing it was still calling the openlibm version and not the pure julia implementation.